Skip to content

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jul 23, 2022

Stage 1 check has been supported since #81064.
#81064 changed the error message for this, but I don't think there's any reason we should prevent using it.
I tested locally and keep-stage works fine.

r? @Mark-Simulacrum

@rustbot rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 23, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 23, 2022
Stage 1 check has been supported since rust-lang#81064.
 rust-lang#81064 changed the error message for this, but I don't think there's any reason we should prevent using it.
I tested locally and `keep-stage` works fine. Don't give a hard error when trying to use it.
@jyn514 jyn514 force-pushed the keep-stage-check branch from 3952607 to 2c70b6a Compare July 30, 2022 00:02
@jyn514 jyn514 changed the title support --keep-stage 0 check Support x --keep-stage 0 check Jul 30, 2022
@jyn514 jyn514 assigned Mark-Simulacrum and unassigned jyn514 Jul 30, 2022
@jyn514 jyn514 marked this pull request as ready for review July 30, 2022 00:03
@Mark-Simulacrum
Copy link
Member

Seems OK.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 30, 2022

📌 Commit 2c70b6a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2022
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#99650 (Support `x --keep-stage 0 check`)
 - rust-lang#99873 (rustdoc: align invalid-html-tags lint with commonmark spec)
 - rust-lang#99889 (Remove `parent_pat` from `TopInfo`)
 - rust-lang#99890 (Do not allow bad projection term to leak into the type checker)
 - rust-lang#99937 (Reset directory iteration in remove_dir_all)
 - rust-lang#99950 (Remove more Clean trait implementations)
 - rust-lang#99956 (Also gate AllocatedPointer and AllocAlign definitions by LLVM_VERSION_GE)
 - rust-lang#99962 (Discover channel for LLVM download)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 44c4b4a into rust-lang:master Jul 30, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 30, 2022
@jyn514 jyn514 deleted the keep-stage-check branch February 25, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants